[fix] battleRoom 이탈 관련 grace period 개선#208
Merged
Hidden character warning
The head ref may contain hidden characters: "fix/196-battleroom-\uc774\ud0c8-\uad00\ub828-\uc218\uc815"
Merged
Conversation
2 tasks
suyeonTech
approved these changes
Apr 12, 2026
zunobk
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
최종 수정
BattleDisconnectHandler.javapublisher필드/생성자 제거, disconnect 시 즉시 publish 제거GracePeriodConsumer.javaPARTICIPANT_LEFT→PARTICIPANT_STATUS_CHANGED(ABANDONED)BattleRoomService.javajoinRoomABANDONED 재입장 시 항상PARTICIPANT_STATUS_CHANGED(PLAYING)발행BattleDisconnectHandlerTest.javapublisher검증 제거,never().publish()추가GracePeriodConsumerTest.javaBattleRoomServiceJoinRoomTest.java주요 변경 내용
BattleDisconnectHandler — disconnect 시 즉시 publish 제거
GracePeriodConsumer — 메시지 타입 변경
BattleRoomService.joinRoom() — 재입장 시 항상 PLAYING 발행
변경 전/후 비교
1. disconnect 직후
PARTICIPANT_STATUS_CHANGED(ABANDONED)즉시 발행2. 15초 내 재입장
PARTICIPANT_STATUS_CHANGED(PLAYING)발행PARTICIPANT_STATUS_CHANGED(PLAYING)발행idempotent덮어쓰기)3. 15초 후에도 미복귀
PARTICIPANT_LEFTPARTICIPANT_STATUS_CHANGED(ABANDONED)4. 15초 후 재입장 (grace 만료 뒤) — 동일
PARTICIPANT_STATUS_CHANGED(PLAYING)발행PARTICIPANT_STATUS_CHANGED(PLAYING)발행핵심 변화 한 줄 요약